Skip to content

feat!: add csi support and replace router_nodepool by default_nodepool #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hbollon merged 3 commits into from
Oct 29, 2025
Merged

feat!: add csi support and replace router_nodepool by default_nodepool #15

hbollon merged 3 commits into from
Oct 29, 2025

Conversation

@hbollon
Copy link
Member

@hbollon hbollon commented Oct 15, 2025

Description of the changes

  • CSI is now available with SKS and it's way better than Longhorn.
  • A dedicated router nodepool isn't needed anymore with SKS, there is no more loopback issues. I renamed a variable used to avoid misunderstanding so this is breaking.

Breaking change

  • No
  • Yes

@hbollon hbollon requested a review from a team as a code owner October 15, 2025 11:58
@hbollon hbollon force-pushed the migration-is-internal branch from dc3e608 to 07d7a0e Compare October 15, 2025 12:14
@hbollon hbollon mentioned this pull request Oct 15, 2025
Merged
8 tasks
lentidas
lentidas approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@lentidas lentidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved!

⚠️ I've added an exclamation mark to your PR title, so if you do a squash and merge, you should be good to create a release with a major bump.

If you prefer to do a rebase, I'll gladly re-review ;)

@lentidas lentidas changed the title feat: add csi support and replace router_nodepool by default_nodepool feat!: add csi support and replace router_nodepool by default_nodepool Oct 16, 2025
@hbollon hbollon merged commit 4c1a703 into main Oct 29, 2025
@hbollon hbollon deleted the migration-is-internal branch October 29, 2025 14:37
@hbollon hbollon restored the migration-is-internal branch October 29, 2025 14:38
@github-actions github-actions bot mentioned this pull request Oct 29, 2025
Merged
@hbollon hbollon deleted the migration-is-internal branch October 29, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentidas lentidas lentidas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hbollon @lentidas