Skip to content

Allow JSON 2 to be used#48

Merged
jdennes merged 1 commit intocampaignmonitor:masterfrom
jacobbednarz:allow-json-2
Jan 14, 2017
Merged

Allow JSON 2 to be used#48
jdennes merged 1 commit intocampaignmonitor:masterfrom
jacobbednarz:allow-json-2

Conversation

@jacobbednarz
Copy link
Contributor

Updates the gem to allow JSON 2.x instead of just the 1.x range.

Updates the gem to allow JSON 2.x instead of just the 1.x range.
@jacobbednarz
Copy link
Contributor Author

Really, you could probably lose the version restriction entirely but up to you :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5e21ed on jacobbednarz:allow-json-2 into ba5e086 on campaignmonitor:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5e21ed on jacobbednarz:allow-json-2 into ba5e086 on campaignmonitor:master.

@jacobbednarz
Copy link
Contributor Author

The CI failure at https://travis-ci.org/campaignmonitor/createsend-ruby/jobs/189424440 is a failure on 1.9.3.

The JSON gem dropped support for MRI 1.9.3. How important is 1.9.3 compatibility for you folks?

@tinogomes
Copy link
Contributor

bump 👍

@jdennes
Copy link
Contributor

jdennes commented Jan 14, 2017

How important is 1.9.3 compatibility for you folks?

I'm not really an active maintainer, but it makes sense to drop support for 1.9.3. I'll release a new version soon.

@jdennes jdennes merged commit e553796 into campaignmonitor:master Jan 14, 2017
@jacobbednarz jacobbednarz deleted the allow-json-2 branch January 14, 2017 21:10
@jacobbednarz
Copy link
Contributor Author

Thanks! 🏆

@tinogomes
Copy link
Contributor

TYSM \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants