Conversation
ijer
reviewed
Dec 14, 2021
ijer
left a comment
ijer
left a comment
There was a problem hiding this comment.
Great job Henry - just minor changes to the history file and that should be it
HISTORY.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ## v7.0.0 - 19 Nov, 2021 | |||
HISTORY.md
Outdated
| ## v7.0.0 - 19 Nov, 2021 | ||
| * Upgrades to Createsend API v3.3 which includes new breaking changes | ||
| * Breaking: 'client.campaigns' now returned an object to support pagination (use .Results to get the array of campaigns) | ||
| * Breaking: various subscribers related endpoints now returned listJoinedDate along with stateChangedDate (previously known as Date) |
AlexisT-CM
pushed a commit
that referenced
this pull request
Jan 23, 2025
EL-360 -- Update to cater for the subscriber endpoints
AlexisT-CM
pushed a commit
that referenced
this pull request
Jan 23, 2025
EL-360 -- Update to cater for the subscriber endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had made the changes and re-run the tests again (NB: tests are independent from the actual endpoint as we are using mock data)