-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For 3.7.5 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
birm
commented
May 28, 2020
•
edited
Loading
edited
- Safer HTML in table (#401)
* Fixed typo for return * Fix for refresh during first slide upload * Fixed refresh on first slide upload * Added space after 'if' for eslint configuration * Added functionality to delete slide from system * Removed refresh on first slide upload * Added alert for slide deletion success * Update to fix linting errors * Update to fix linting errors * Fix linting errors * Fix lint errors * Fix lint error * Rechained promises to handle mishandled slide deletions * style fix * Added delete slide request functionality * style fix * style fix * style fix * style fix * style fix * Client side changes for handling new 'requests' collection * merge fix * merge fix * Fix for direct deletion of slides * style fix * Added feature for user registration requests * style fix * Commented line stating that signup page is just for admins * Added line explaining new workflow of signup page * Added popups for success instead of alerts and moved showSuccessPopup to util.js for reusability * Comment fix * Style fix * Solved permsisions is not defined error in signup.html * Comment fix * catch promise error Co-Authored-By: Ryan Birmingham <birm@rbirm.us> * error handling on fetching requests Co-Authored-By: Ryan Birmingham <birm@rbirm.us> * Update apps/table.html * modifications for handling prototype * removed unwanted console.logs * Update functions to handle first time user registrations * Fix to a missing .html extension * Updated HISTORY.md * Added links to PRs * Fixed index links * Grammar fix Co-authored-by: Ryan Birmingham <birm@rbirm.us> Co-authored-by: Ryan Birmingham <birm@rbirm.us>
Added download button in slide viewer [Enhancement]
* filters warning div * lint table.js * changeSlideName * userCreateRequest * lintfix * lazily try sanitize() * use classList.add * some back to addClass * fix1 - rebase later * fix filter list render * try label instead * fallback for sanitize * replace this in onchange/click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.