Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Loader Enhancement #389

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Conversation

akhil-rana
Copy link
Contributor

Description

Some features are added to the batch loader:

  • Delete Functionality to remove the slide.
  • Individual Slidename and FIlename change functionality.
  • Info icon is added which to every row which on click describes various information about the slide like original filename, filename , slide name, status, token etc.
  • Filename/slidename validation during individual edit.

Motivation and Context

How Has This Been Tested?

Tested on:

  • Mozilla 75.0, Chrome 81.0
  • Ubuntu 19.10

Screenshots:

chrome-2020-04-20_09 13 27

chrome-2020-04-20_09 09 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@akhil-rana
Copy link
Contributor Author

@birm
About the original file name. I have added it inside the Slide info
If you think that a new column should be added for the same, please let me know.

@birm birm self-requested a review April 20, 2020 14:54
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
This is good, with the addition of informing users of errors. If it put in a bad filename, it just silently fails, for example.

@akhil-rana
Copy link
Contributor Author

Thanks for the review.
I'm working on those.
And some more minor things. Will push the changes soon.

@birm
Copy link
Member

birm commented Apr 21, 2020

Of course, since this is an early app, there are still some things to hammer out. Up to you how much/little goes into each PR. (For example, the batch slide name field could be smart enough to borrow the file extension from the original filenames)

@akhil-rana
Copy link
Contributor Author

akhil-rana commented Apr 21, 2020

Umm, what if the multiple files have different extensions?
I'm thinking that maybe I don't take the file extension as batch file name input. And allow user to change extension (idk if I should) in the individual file name change.
Also, I am not sure if the file extension change should be allowed in the first place, or not?

What do you think? @birm

@birm
Copy link
Member

birm commented Apr 21, 2020

I think it's reasonable to have it use the source's file extension, though if someone goes in to manually change it, that's on them :)

@akhil-rana
Copy link
Contributor Author

The following changes have been made:

  • Basic transition animations
  • General file name is now taken without file extension and file extensions are automatically picked up from the source file. Moreover user can change the file extension individually if required.
  • Filenames field now converts any white spaces to underscore automatically.
  • Slide names are now sanitized automatically.
  • File input now allows the user to select only the allowed file extensions from the file manager (at default).
  • The error icons will be shown if the user general file/slide name matches the already existing files/slides or if in case user forcefully selects non supported files in the file browser. And the user will not be allowed to proceed further (upload button hidden) until all the errors are resolved.
  • File extension validation during file name edit.
  • Some more UX changes like.. automatic focus of textfield on slide/file name change, automatically select the file name (excepting the extension).

chrome-2020-04-22_04 55 32

chrome-2020-04-22_04 57 13

@akhil-rana akhil-rana requested a review from birm April 22, 2020 00:06
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the work and changes!

@birm birm merged commit 6d193ba into camicroscope:develop Apr 22, 2020
@birm birm mentioned this pull request Apr 22, 2020
@akhil-rana akhil-rana deleted the batchloader_enhance branch June 18, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants