Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend modifications for timestamp based first time signup #388

Merged
merged 59 commits into from
Apr 28, 2020
Merged

Frontend modifications for timestamp based first time signup #388

merged 59 commits into from
Apr 28, 2020

Conversation

Vedant1202
Copy link
Contributor

@Vedant1202 Vedant1202 commented Apr 19, 2020 •
edited
Loading

Description

Change in signup function to accomodate for timestamp based user signup. This is for first time server setup, so that users can add actual admin accounts directly. This depends upon Caracal PR-26 and Distro PR-122.

Motivation and Context

How Has This Been Tested?

**Please describe in detail how you tested your changes.

  • Tested on Ubuntu 18.04 and Firefox
  • This change does not affect other areas of code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Vedant1202 and others added 30 commits April 6, 2020 01:43
@Vedant1202
Fixed typo for return
048c569
@Vedant1202
merge fix
61661f6
@Vedant1202
Fix for refresh during first slide upload
85c4997
@Vedant1202
Fixed refresh on first slide upload
6979fa8
@Vedant1202
Added space after 'if' for eslint configuration
50b2cc8
@Vedant1202
Added functionality to delete slide from system
1e94b81
@Vedant1202
Merge branch 'develop' of https://github.com/Vedant1202/caMicroscope …
8f1c7f6 
…into develop
@Vedant1202
Removed refresh on first slide upload
31460c7
@Vedant1202
Added alert for slide deletion success
9f2438a
@Vedant1202
Update to fix linting errors
e8bbcd8
@Vedant1202
Update to fix linting errors
b0cef11
@Vedant1202
Fix linting errors
4e2bf41
@Vedant1202
Fix lint errors
37fd15c
@Vedant1202
Fix lint error
7bbc144
@Vedant1202
Rechained promises to handle mishandled slide deletions
27b5299
@Vedant1202
Merge fix
8477ee6
@Vedant1202
Merge fix
2d805a8
@birm
style fix
3411a5d
@Vedant1202
Added delete slide request functionality
be0480c
@Vedant1202
Merge branch 'develop' of https://github.com/camicroscope/caMicroscope …
59cc361 
…into develop
@Vedant1202
merge fix
0c9e74d
@Vedant1202
style fix
31763f3
@Vedant1202
style fix
51f6552
@Vedant1202
style fix
554e5c5
@Vedant1202
style fix
0ce49cc
@Vedant1202
style fix
2055317
@Vedant1202
Merge branch 'develop' into develop
b5082cc
@Vedant1202
Client side changes for handling new 'requests' collection
a51c0a2
@Vedant1202
merge fix
0f67e0a
@Vedant1202
merge fix
0157d35
Vedant1202 and others added 19 commits April 16, 2020 22:40
@Vedant1202
Commented line stating that signup page is just for admins
5612529
@Vedant1202
Added line explaining new workflow of signup page
ca8919d
@Vedant1202
Merge branch 'develop' into develop
2076b0c
@Vedant1202
Added popups for success instead of alerts and moved showSuccessPopup…
03f00c9 
… to util.js for reusability
@Vedant1202
Comment fix
14195ce
@Vedant1202
Style fix
e801362
@Vedant1202
Merge branch 'develop' of https://github.com/camicroscope/caMicroscope …
0c2b5ac 
…into develop
@Vedant1202
Merge branch 'develop' of https://github.com/camicroscope/caMicroscope …
d3ca2e2 
…into develop
@Vedant1202
Solved permsisions is not defined error in signup.html
7e8d644
@Vedant1202
Merge branch 'develop' of https://github.com/Vedant1202/caMicroscope …
2cd0aef 
…into develop
@Vedant1202
Comment fix
e89ec80
@Vedant1202 @birm
catch promise error
d3fd9ab 
Co-Authored-By: Ryan Birmingham <birm@rbirm.us>
@Vedant1202 @birm
error handling on fetching requests
e2924e7 
Co-Authored-By: Ryan Birmingham <birm@rbirm.us>
@birm
Merge branch 'develop' into develop
46849bd
@birm
Update apps/table.html
52d9ac1
@Vedant1202
modifications for handling prototype
602d459
@Vedant1202
removed unwanted console.logs
bf87da7
@Vedant1202
merge fix
d76c259
@Vedant1202
Merge branch 'develop' of https://github.com/Vedant1202/caMicroscope …
636c41e 
…into develop
This was referenced Apr 19, 2020
Merged
Merged
@birm birm self-requested a review April 26, 2020 22:10
@Vedant1202 Vedant1202 changed the title Prototype token handling for first time signup Frontendmodifications for timestamp based first time signup Apr 27, 2020
@Vedant1202 Vedant1202 changed the title Frontendmodifications for timestamp based first time signup Frontend modifications for timestamp based first time signup Apr 27, 2020
@Vedant1202
Copy link
Contributor Author

@birm This is also necessary for timestamp based signup to work. Please review and tell me if any changes are required.

@birm birm merged commit 9487b88 into camicroscope:develop Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birm birm birm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vedant1202 @birm