Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Implementation of batch slide loader #385

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

akhil-rana
Copy link
Contributor

@akhil-rana akhil-rana commented Apr 18, 2020

Description

  • A new batch slide loader app page has been created at /apps/batchloader/ to upload multiple files simultaneously with ease.
  • Slide name can be generated by the user provided name eg. sample_1,sample_2 etc.
  • File names can either be set to default (original file names) or can be generated similar to the slide name.
  • This is an initial implementation and I look forward to suggestions and feedback.
  • Working on better implementation of validation and error handling.
  • Some functions in batchLoader.js are modified from chunked_loader.js and loader.js to behave accordingly since I was trying to solve the issue without making changes in slideLoader(at least for now).

Motivation and Context

**Why is this change required? What problem does it solve?

How Has This Been Tested?

  • Tested on Mozilla 75.0, Chrome 81.0
  • Ubuntu 19.10

Screenshots (if appropriate):

Please click on the gif to view in full screen if not visible clearly here.

chrome-2020-04-19_03 45 16-online-video-cutter com-min

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@akhil-rana
Copy link
Contributor Author

@birm
Am I heading in the right direction here?

@birm birm self-requested a review April 18, 2020 23:19
@birm
Copy link
Member

birm commented Apr 18, 2020

That's pretty cute! I'll review it more deeply in a bit.

@birm
Copy link
Member

birm commented Apr 19, 2020

One little change for now; can we add a column which shows what the filename of the original file was?

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'll approve this, as it's a reasonable initial implementation. I'll comment in the source issue for extending it. Thanks for the good work!

@birm birm merged commit cbadf6b into camicroscope:develop Apr 19, 2020
@akhil-rana
Copy link
Contributor Author

akhil-rana commented Apr 19, 2020

Thank you.
I will be working on this to improve this more.

@birm birm mentioned this pull request Apr 22, 2020
@akhil-rana akhil-rana deleted the batchLoader branch June 18, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants