Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] replace alerts to toasts in viewer #383

Merged
merged 3 commits into from
Apr 18, 2020

Conversation

mgautam98
Copy link
Contributor

@mgautam98 mgautam98 commented Apr 17, 2020

Description

Toast for no heatmap data instead of alert
Toast for no markup on annotation instead of alert
Documented functions inside viewer uicallbacks.js

Motivation and Context

**Why is this change required? What problem does it solve?

  • Documenting code is good for fast development.
  • Replacing alerts with toasts to improve UX

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

apps/model/model.js Outdated Show resolved Hide resolved
@birm birm self-requested a review April 18, 2020 00:02
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for:

  • the ui improvement
  • increasing our documentation coverage
  • working with my comment

@birm birm merged commit cf5514d into camicroscope:develop Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants