Skip to content

Conversation

@cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 17, 2020

Description

The following changes have been made in sorting approach for slides page, to keep it a lot similar to that of the information-dashboard page

  • The 2 separate icons for up and down arrow are replaced by a single icon for sorting
  • The information for index and order is stored in data-* attributes of the span tag, so as to simplify the code for sorting and making it more understandable

Motivation and Context

  • Earlier, there were 2 separate icons for sorting which was not creating a good user experience
  • The code for sorting earlier used to store the title in some part of the id, then extract it using substr() function and then match it with available headings to find out the index of the column, increasing the complexity and decreasing the readability of the code.

How Has This Been Tested?

  • Tested in both Chrome and Firefox

Screenshots:

sort-slides

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@birm birm self-requested a review April 17, 2020 14:37
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@birm birm merged commit d521a82 into camicroscope:develop Apr 17, 2020
@cjchirag7 cjchirag7 deleted the improve-sort-slides branch April 17, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants