Skip to content

Conversation

@cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 17, 2020

Description

  • Display a show more option when the content of a column is very huge during the 'check' stage, so that the user can view the whole content of that particular column only when he needs to.
  • Currently, if a content has a length>65, then only this option is shown.

Motivation and Context

How Has This Been Tested?

  • Tested in both Chrome and Firefox, in desktop as well as mobile view.

Screencast :

show-more-check-upload

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cjchirag7 cjchirag7 changed the base branch from master to develop April 17, 2020 07:02
@cjchirag7 cjchirag7 changed the title More option in check status during slide upload [ UI Enhancement More option in check status during slide upload [ UI Enhancement ] Apr 17, 2020
@birm birm self-requested a review April 17, 2020 14:37
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this fix. I was tempted to just ignore comment, but this is more useful. Thanks!

@birm birm merged commit fdf2eb3 into camicroscope:develop Apr 17, 2020
@cjchirag7 cjchirag7 deleted the more-option-upload-preview branch April 17, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants