Skip to content

Conversation

@Vedant1202
Copy link
Contributor

@Vedant1202 Vedant1202 commented Apr 16, 2020

Description

This update enables non-admins to request admins for creating new users. The admin notification menu is updated to contain both type of requests (user signup and slide deletion).

The changes are:

  • Non-admins can now request for user signup.
  • Admins can accept or decline the user signup requests.
  • Admin notification menu has divided tabs. One for slide deletion requests and another for user signup requests (this can be viewed in the screencasts below).

**(Edit)

  • Change alerts to popups on function success.
  • Moved showSuccessPopup to util.js for reusability.

Motivation and Context

This will enable a non-admin to be able to request to create users, thus enhancing the flexibility of user signup process, as the signup process gets distributed within various types of users.

How Has This Been Tested?

This feature has been tested in an environment with enabled security protocols.

  • Tested on Ubuntu 18.04, Firefox browser.
  • These changes do not affect other features.

Screenshots (if appropriate):

  1. Non-admin creates a user signup request
    request

  2. Admins can either decline or accept the request.
    accept-decline

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. (@birm does it, please help?)
  • I have updated the documentation accordingly.

@Vedant1202
Copy link
Contributor Author

Yeah done, thanks.

@birm
Copy link
Member

birm commented Apr 16, 2020

Ah, it looks like we've made a conflict for you... Do you mind having a look?

@Vedant1202
Copy link
Contributor Author

Yup, done

@Vedant1202
Copy link
Contributor Author

Changed success alerts to popup messages and moved popup function to util.js for reusability across pages

@Vedant1202
Copy link
Contributor Author

@birm I'm done with the changes, you can review them.

@birm
Copy link
Member

birm commented Apr 17, 2020

What combinations of disable sec and allow public did you test?

@Vedant1202
Copy link
Contributor Author

Vedant1202 commented Apr 17, 2020

@birm umm, sorry I missed the earlier comment. I tested disable security as false and true with keeping allow public as false. Please tell me if you are facing any issue over there.

Also, thanks for the suggestions, I've made the changes.

@birm birm self-requested a review April 17, 2020 17:59
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the confusion I've introduced with my last review.

@birm birm merged commit ffc0a90 into camicroscope:develop Apr 17, 2020
This was referenced Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants