-
Notifications
You must be signed in to change notification settings - Fork 308
User signup request feature for non-admins #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yeah done, thanks. |
|
Ah, it looks like we've made a conflict for you... Do you mind having a look? |
|
Yup, done |
… to util.js for reusability
|
Changed success alerts to popup messages and moved popup function to util.js for reusability across pages |
|
@birm I'm done with the changes, you can review them. |
|
What combinations of disable sec and allow public did you test? |
Co-Authored-By: Ryan Birmingham <birm@rbirm.us>
Co-Authored-By: Ryan Birmingham <birm@rbirm.us>
|
@birm umm, sorry I missed the earlier comment. I tested disable security as false and true with keeping allow public as false. Please tell me if you are facing any issue over there. Also, thanks for the suggestions, I've made the changes. |
birm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the confusion I've introduced with my last review.
Description
This update enables non-admins to request admins for creating new users. The admin notification menu is updated to contain both type of requests (user signup and slide deletion).
The changes are:
**(Edit)
Motivation and Context
This will enable a non-admin to be able to request to create users, thus enhancing the flexibility of user signup process, as the signup process gets distributed within various types of users.
How Has This Been Tested?
This feature has been tested in an environment with enabled security protocols.
Screenshots (if appropriate):
Non-admin creates a user signup request

Admins can either decline or accept the request.

Types of changes
Checklist: