Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slide name change functionality & direct slide delete in No-Security Mode #367

Merged
merged 7 commits into from
Apr 15, 2020
Merged

Slide name change functionality & direct slide delete in No-Security Mode #367

merged 7 commits into from
Apr 15, 2020

Conversation

akhil-rana
Copy link
Contributor

Slide name can be updated by the user who have the proper permissions.
ezgif-2-43ced679a2b2

@birm birm self-requested a review April 15, 2020 14:45
@birm birm mentioned this pull request Apr 15, 2020
Merged
@akhil-rana akhil-rana changed the title Slide name change functionality Slide name change functionality & direct slide delete in No-Security Mode Apr 15, 2020
@akhil-rana
Copy link
Contributor Author

The delete functionality is now checked using the user permissions rather than userType, so slide deletion can now be directly done if security is turned off.
Also, for user who can delete directly, 'delete' text inside the button is replaced by only the icon, like before.

birm
birm approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the feature and fix!

@birm birm merged commit e5e7d36 into camicroscope:develop Apr 15, 2020
@birm birm mentioned this pull request Apr 17, 2020
Merged
@akhil-rana akhil-rana deleted the slideNameUpdate branch June 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birm birm birm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhil-rana @birm