Skip to content

Convert space to underscore and validate extension, on change of filename #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birm merged 1 commit into from
Apr 7, 2020
Merged

Convert space to underscore and validate extension, on change of filename #344

birm merged 1 commit into from
Apr 7, 2020

Conversation

@cjchirag7
Copy link
Contributor

@cjchirag7 cjchirag7 commented Apr 7, 2020

Closes #343
Added the following features

  • Convert spaces (' ') to underscores('_') on 'change' event in FileName.
  • Validate the extension on 'change' event in FileName and display error message, appropriately

Screencast
space-extension-check-new

@birm birm self-requested a review April 7, 2020 18:42
@birm birm merged commit 3d2f43d into camicroscope:develop Apr 7, 2020
@birm birm mentioned this pull request Apr 7, 2020
Closed
@cjchirag7 cjchirag7 deleted the fix-filename-issues branch April 7, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birm birm birm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjchirag7 @birm