Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix popup close on hidden segment #330

Merged
merged 2 commits into from
Apr 7, 2020
Merged

fix popup close on hidden segment #330

merged 2 commits into from
Apr 7, 2020

Conversation

mgautam98
Copy link
Contributor

After hiding a segment popup still used to stick on the screen.

ezgif com-video-to-gif (3)

After this fix the popup will close as soon as the corresponding segment hides.

ezgif com-video-to-gif (4)

@birm birm self-requested a review April 7, 2020 14:49
@birm birm merged commit f1ae537 into camicroscope:develop Apr 7, 2020
@mgautam98 mgautam98 deleted the patch-111 branch April 9, 2020 09:10
@birm birm mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birm birm birm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgautam98 @birm