Skip to content

Conversation

@akhil-rana
Copy link
Contributor

@akhil-rana akhil-rana commented Apr 5, 2020

The page indicator will only be visible when the number of pages are greater than 1.
No indicator will be shown if there is only 1 page.

Copy link
Contributor

@cjchirag7 cjchirag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . Tested it locally, working fine.

@birm birm self-requested a review April 5, 2020 18:00
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@birm birm merged commit 8254d7f into camicroscope:develop Apr 5, 2020
@akhil-rana akhil-rana deleted the PageIndicatorVisibility branch June 18, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants