Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spyglass out of window #275

Merged
merged 4 commits into from
Mar 31, 2020
Merged

fix spyglass out of window #275

merged 4 commits into from
Mar 31, 2020

Conversation

mgautam98
Copy link
Contributor

The spyglass goes out of the window at all of the corners like this

spyglass

This this fix it won't go out of window at the corners

Screenshot from 2020-03-30 04-00-37
Screenshot from 2020-03-30 04-01-33

@birm
Copy link
Member

birm commented Mar 29, 2020

Good, the CI linting is working. Sorry to have introduced a style guide in the middle of your PR work.

You can probably auto-fix these with eslint components/spyglass/spyglass.js --fix.

@mgautam98
Copy link
Contributor Author

That's actually great. We really needed it. I will ping you after making changes. Thanks

@mgautam98
Copy link
Contributor Author

@birm config file is giving this

ESLint couldn't find the config "google" to extend from. Please check that the name of the config is correct.

The config "google" was referenced from the config file in "/home/gautam/Projects/caMicroscope/.eslintrc.js"

@birm
Copy link
Member

birm commented Mar 30, 2020

In order to have it work on CI at least, we needed to install both eslint and eslint-config-google as non-global and use that binary. That is,

npm install eslint
npm install eslint-config-google
./node_modules/.bin/eslint core/*.js 

@mgautam98
Copy link
Contributor Author

@birm fixed the style.

@birm birm requested a review from nanli-emory March 31, 2020 02:05
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Opening up to @nanli-emory for comments on behavior.

@birm birm merged commit bb58a8f into camicroscope:develop Mar 31, 2020
This was referenced Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants