Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for existing slide name #266

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Validation for existing slide name #266

merged 2 commits into from
Mar 29, 2020

Conversation

mgautam98
Copy link
Contributor

While uploading new slide users are not notified if slide name is already taken. And multiple copies of same name exists. Due to this it creates bad user experience because
later users will not know what work they have done in which slide by looking at name.

Multiple slides with same name
Screenshot from 2020-03-29 11-38-55

Now it will be validated just like empty slide name.
Screenshot from 2020-03-29 11-38-14

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is helpful! Thanks!

@birm birm merged commit 61627ae into camicroscope:develop Mar 29, 2020
@birm birm mentioned this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants