Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all memory leaks in segmentation view #261

Merged
merged 4 commits into from
Mar 28, 2020
Merged

Fixed all memory leaks in segmentation view #261

merged 4 commits into from
Mar 28, 2020

Conversation

AbdulRashidReshamwala
Copy link
Contributor

Fixed Memory Issue Mentioned in #228 caued by tf.browser.toPixels()
Before:
Screenshot from 2020-03-27 20-06-36
After:
Screenshot from 2020-03-27 20-54-57

@AbdulRashidReshamwala
Copy link
Contributor Author

Also added memory logging in segment view

@birm birm changed the base branch from master to develop March 27, 2020 20:26
@birm
Copy link
Member

birm commented Mar 27, 2020

@Insiyaa any thoughts?

Insiyaa
Insiyaa suggested changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@Insiyaa Insiyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dispose() calls aren't required as tf.tidy() does that; rest it's perfect, thank you for this fix!

@AbdulRashidReshamwala
Copy link
Contributor Author

Completed all the suggestions please review @birm @Insiyaa

@birm birm merged commit eff6fb0 into camicroscope:develop Mar 28, 2020
@AbdulRashidReshamwala AbdulRashidReshamwala deleted the model-memory-issue branch March 28, 2020 15:10
@birm birm mentioned this pull request Mar 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birm birm birm approved these changes

@Insiyaa Insiyaa Insiyaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbdulRashidReshamwala @birm @Insiyaa