Fixed nav bar not responsive on landing page. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akhil-rana
commented
Mar 26, 2020
akhil-rana
commented
- The navbar on the landing page was not responsive and all the content suddenly disappeared when the page is accessed from a smaller screen.
- The content of the navbar was not of same font and size on landing and slides page and that looks a little uneven when switching from one page to other.
- Signup option was not present on the slides page.
|
The first image was before when the navbar was not reponsive. |
birm
reviewed
Mar 26, 2020
Comment on lines
+75
to
+77
| <li class="nav-item link" style="font-family: sans-serif;"> | ||
| <a class="nav-link" href="./signup/signup.html">Signup</a> | ||
| </li> |
There was a problem hiding this comment.
I'm a little divided on if table needs a signup page, but I think it makes sense for consistency.
There was a problem hiding this comment.
We should have a discussion about the registration process before working on the signup page.
|
As can be seen that the navbar height, font size and style was not constant for both the pages. Also the signup option was not present on the slides page. |
birm
approved these changes
Mar 26, 2020
nanli-emory
approved these changes
Mar 26, 2020
Comment on lines
+75
to
+77
| <li class="nav-item link" style="font-family: sans-serif;"> | ||
| <a class="nav-link" href="./signup/signup.html">Signup</a> | ||
| </li> |
There was a problem hiding this comment.
We should have a discussion about the registration process before working on the signup page.
birm
added a commit
that referenced
this pull request
Mar 26, 2020
Co-authored-by: Ryan Birmingham <birm@rbirm.us> Co-authored-by: Nan Li <linanldj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.