-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed nav bar not responsive on landing page. #252
Fixed nav bar not responsive on landing page. #252
Conversation
akhil-rana
commented
Mar 26, 2020
- The navbar on the landing page was not responsive and all the content suddenly disappeared when the page is accessed from a smaller screen.
- The content of the navbar was not of same font and size on landing and slides page and that looks a little uneven when switching from one page to other.
- Signup option was not present on the slides page.
<li class="nav-item link" style="font-family: sans-serif;"> | ||
<a class="nav-link" href="./signup/signup.html">Signup</a> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little divided on if table needs a signup page, but I think it makes sense for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a discussion about the registration process before working on the signup
page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good, but I'll want to wait until Nan shares thoughts on bootstrap before merging. Thanks for helping us make caMicroscope more mobile ready!
<li class="nav-item link" style="font-family: sans-serif;"> | ||
<a class="nav-link" href="./signup/signup.html">Signup</a> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a discussion about the registration process before working on the signup
page.
Co-authored-by: Ryan Birmingham <birm@rbirm.us> Co-authored-by: Nan Li <linanldj@gmail.com>