Fixes #1065 Removes the duplicate link on signup page#1066
Merged
birm merged 3 commits intoJan 11, 2025
Conversation
chandrikarj
changed the title
birm
approved these changes
Jan 11, 2025
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Low stakes so an easy approve! Good eye!
Contributor
Author
|
Thanks for approving! @birm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1065. Removes the duplicate display of 'Already have an account' link on Signup Page.
Summary
This pull request removes the duplicate "Already have an account?" link on the signup page. The page now displays only a single instance of the link, simplifying the user interface.
Before:
After:
Motivation
The duplicate link created redundancy and potential confusion for users. By removing the extra instance, the signup page is more user-friendly and maintains a cleaner design.
Testing
Manually tested the page to ensure that only one "Already have an account?" link is displayed.
Verified that the remaining link retains its existing functionality and does not break the layout.
Questions
The link is currently leads to a 404 error. Clarification on the exact nature of it's expected functioning would help me fix the link's functionality accurately.