Simplify and support IE #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the way we manage transfer data. Instead of smuggling a unique key in the mimetype of the event's
transferData, we're setting a single key on a globally available object, and overwriting it with each drag interaction. As a result, we're not even using the nativetransferDataobject at all, so IE compatibility is no longer a concern.I'm not sure if this is going to screw anything up. The only scenario I can imagine it being a problem is if there are somehow multiple drag actions in progress at the same time. Maybe in some kind of multitouch scenario? I don't know, it seems unlikely to be a problem.