Feature #6 tag selection for drag and drop element #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for doing this! |
cameronhimself
requested changes
Nov 10, 2017
src/Drop.vue
Outdated
| @@ -16,8 +16,11 @@ | |||
| const insideElements = new Set(); | |||
|
|
|||
| export default { | |||
| props: { | |||
| tag: { type: String, default: 'div' }, | |||
| }, | |||
There was a problem hiding this comment.
Please use tabs for indentation.
README.md
Outdated
| ### `tag` | ||
| **validation** `String` | ||
| **default**: `div` | ||
| Drag or Drop element's wrapper , defaults to div |
There was a problem hiding this comment.
Can you add a period to the end, and remove the space before the comma?
src/Drop.vue
Outdated
| data: () => ({ dataKey: null }), | ||
| computed: { | ||
| computed: { |
There was a problem hiding this comment.
It doesn't look like this indentation should be changed.
|
@cameronhimself, done |
cameronhimself
approved these changes
Nov 17, 2017
|
I'll publish to npm this weekend. Thanks again! |
Closed
|
Hello,
I cant see a released version on npm yet. When will you release to npm?
-------- Ursprüngliche Nachricht --------Von: "J. Cameron McDonald" <notifications@github.com> Datum: 17.11.17 21:20 (GMT+01:00) An: cameronhimself/vue-drag-drop <vue-drag-drop@noreply.github.com> Cc: akubasa <a.kubasa@at-visions.com>, Author <author@noreply.github.com> Betreff: {Disarmed} Re: [cameronhimself/vue-drag-drop] Feature #6 tag selection for drag and drop element (#10)
I'll publish to npm this weekend. Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/cameronhimself/vue-drag-drop","title":"cameronhimself/vue-drag-drop","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/cameronhimself/vue-drag-drop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cameronhimself in #10: I'll publish to npm this weekend. Thanks again!"}],"action":{"name":"View Pull Request","url":"#10 (comment)"}}}
|
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
|
I'm sorry, busy weekend. I'll release tonight after I get off work. |
|
Released! Thanks again, and sorry for the delay. |
|
I say thank you!
-------- Ursprüngliche Nachricht --------Von: "J. Cameron McDonald" <notifications@github.com> Datum: 22.11.17 00:02 (GMT+01:00) An: cameronhimself/vue-drag-drop <vue-drag-drop@noreply.github.com> Cc: akubasa <a.kubasa@at-visions.com>, Author <author@noreply.github.com> Betreff: {Disarmed} Re: [cameronhimself/vue-drag-drop] Feature #6 tag selection for drag and drop element (#10)
Released! Thanks again, and sorry for the delay.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/cameronhimself/vue-drag-drop","title":"cameronhimself/vue-drag-drop","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/cameronhimself/vue-drag-drop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cameronhimself in #10: Released! Thanks again, and sorry for the delay."}],"action":{"name":"View Pull Request","url":"#10 (comment)"}}}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for tag selection in Drag and Drop elements.
Tested and already working with it.