Repository navigation
Consider reviewing the include path for a CMake install #391
Description
Activity
I finally wrote this in my project...
#if __has_include(<blockingconcurrentqueue.h>) #include <blockingconcurrentqueue.h> #elif __has_include(<moodycamel/blockingconcurrentqueue.h>) #include <moodycamel/blockingconcurrentqueue.h> #else #include <concurrentqueue/moodycamel/blockingconcurrentqueue.h> #endif
I finally wrote this in my project...
#if __has_include(<blockingconcurrentqueue.h>)
#include <blockingconcurrentqueue.h>
#elif __has_include(<moodycamel/blockingconcurrentqueue.h>)
#include <moodycamel/blockingconcurrentqueue.h>
#else
#include <concurrentqueue/moodycamel/blockingconcurrentqueue.h>
#endifYes, eventually one needs to bite the bullet and resort to having the client code adjust. I seem to remember that the library in Vcpkg uses yet another header path,
concurrentqueue/blockingconcurrentqueue.h, which is the most sensible one (following the easy-to-guess pattern <library_name>/<header_file_name>). You might check and add it to your trick.OK, thx, 4 branches now😂
Reacted by Federico Aponte
The CMake-based build+install works, but it ends up installing the header files in
include/concurrentqueue/moodycamel. This forces client code to use this header inclusion:While it would be preferable a simpler path, as this.
This is also the path taken by the
concurrentqueueinstallation through Vcpkg and it is in the best interest for the spreading of the library that the two approaches are exactly the same.The line responsible for this, and the only one that should need to be changed is the following.
concurrentqueue/CMakeLists.txt
Line 61 in 6dd38b8
Changed to this.
I could take care of the change, but I need to understand there's agreement on it.
Will this change find acceptance?
NOTE:
Should it be critical to keep the word
moodycamelin the path I'd suggest a more intuitive path.The name of the organization (moodycamel) has a broader scope than the name of the library (concurrentqueue), it feel really weird that the two are inverted.