making the diagnostics computation async #116 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
apupier
reviewed
Oct 31, 2018
There was a problem hiding this comment.
- with big files, validation can take several seconds. and several modifications and call to validation can be called in parallel. So validation markers can be going on and off. It would be nice to cancel previously running validation for the same file. (in another PR maybe)
- I created a PR to use awaitility instead of a while loop with timeout, let me know what you think about it Use Awaitility to check Diagnostic instead of active wait with while lhein/camel-language-server#2
apart from that it is nice to have not block the Save for diagnostic computation!
loop (camel-tooling#116) Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
approved these changes
Nov 5, 2018
|
@lhein any reasons preventing the merge of this PR? |
|
yeah, I have still not tested with big to huge camel files. |
|
tested now with a ~1250 lines camel context file and diagnostics takes a little more than a second. So I guess we are safe to also enable it for each text edit and not only on save time. @apupier |
|
I think it can trigger too many computations in some cases. Anyway, we can try and still revert if user complains. |
|
created #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lars Heinemann lhein.smx@gmail.com