add support for global endpoint uri completion #121 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
previously requested changes
Aug 3, 2018
| int nextQuote = line.indexOf('\"', uriAttribute + 5); | ||
| if (isBetween(characterPosition, uriAttribute + 5, nextQuote)) { | ||
| return line.substring(uriAttribute + 5, nextQuote); | ||
| int firstQuote = line.indexOf('\"', uriAttribute); |
There was a problem hiding this comment.
this is dangerous, if you have another attribute on the same line, for instance the id before, it won't work. you need to keep the search on uri="
if it has not break it worth adding a test for this case (or at least to raise an issue to add it)
There was a problem hiding this comment.
I don't think you are right. I am starting to search in the line at the position of the URI attribute which will most likely be followed by ="value".
|
created #129 to handle global endpoints in Java DSL |
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein
force-pushed
the
globalEndpointSupport_121
branch
from
e602206
to
d76c821
Compare
|
@apupier this one has to be merged first |
apupier
requested changes
Aug 6, 2018
|
needs to be reported in this PR then |
|
reported it |
|
merged as part of #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lars Heinemann lhein.smx@gmail.com