Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Code coverage - including webSocket and StaandardIO tests #313

Open
apupier opened this issue Oct 2, 2019 · 3 comments
Open

Restore Code coverage - including webSocket and StaandardIO tests #313

apupier opened this issue Oct 2, 2019 · 3 comments

Comments

@apupier
Copy link
Member

apupier commented Oct 2, 2019

due to an upgrade in SonarCloud, we lost the code coverage. We need to find how to reenable it.
@apupier apupier mentioned this issue Oct 2, 2019
Closed
@apupier apupier self-assigned this Nov 14, 2019
@apupier
Copy link
Member Author

apupier commented Nov 14, 2019

seems not due to Sonar upgrade but to the added tests on the Runner main class for WebSocket and StandardIo.

If i disable them I have coverage reported locally.

apupier added a commit to apupier/camel-language-server that referenced this issue Nov 15, 2019
@apupier
Rename test with correct case camel-tooling#313
97e8f1c 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Nov 15, 2019
@apupier
Provide partial Coverage camel-tooling#313
67e89aa 
- add back Jacoco configuration
- now Sonar requires the xml report to be generated, it means that we
need to launch verify phase instead of test
- excluding 2 tests from coverage, they are playing and it is causing
Jacoco to not report any coverage 90% of the time. This look alike a bug
in Jacoco, will need to qualify and report it.

So this PR is adding back coverage of the 232 tests over the 238
existing. This is not yet perfect but better than 0.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Nov 15, 2019
@apupier
Rename test with correct case #313
775b00d 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Nov 15, 2019
@apupier
Provide partial Coverage #313
e84292e 
- add back Jacoco configuration
- now Sonar requires the xml report to be generated, it means that we
need to launch verify phase instead of test
- excluding 2 tests from coverage, they are playing and it is causing
Jacoco to not report any coverage 90% of the time. This look alike a bug
in Jacoco, will need to qualify and report it.

So this PR is adding back coverage of the 232 tests over the 238
existing. This is not yet perfect but better than 0.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Nov 15, 2019
@apupier
Revert bad modifications camel-tooling#313
01d080f 
forgot to remove some modifications done during investigations

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Nov 15, 2019
@apupier
Revert bad modifications camel-tooling#313
12711f8 
forgot to remove some modifications done during investigations

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Nov 15, 2019
@apupier
Revert bad modifications camel-tooling#313
ec322ef 
forgot to remove some modifications done during investigations

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Nov 15, 2019
@apupier
Revert bad modifications #313
0a34d28 
forgot to remove some modifications done during investigations

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier removed their assignment Jan 8, 2020
@apupier
Copy link
Member Author

apupier commented Jul 1, 2020

coverage is currently reported without tests on the Runner main class for WebSocket and StandardIo

@apupier apupier changed the title restore Code coverage Restore Code coverage - including webSocket and StaandardIO tests Jul 1, 2020
@apupier
Copy link
Member Author

apupier commented May 20, 2021

wondering if it wasn't caused by some Thread that were leftover:
#605

camel-language-server/src/test/java/com/github/cameltooling/lsp/internal/RunnerStandardIOTest.java

Line 56 in 8c8333e

new Thread(new Runnable() {

apupier added a commit to apupier/camel-language-server that referenced this issue May 20, 2021
@apupier
Restore code coverage for all tests camel-tooling#313
696e984 
remaining threads could cause problem

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Jun 18, 2021
@apupier
Restore code coverage for all tests camel-tooling#313
ec2a3bb 
remaining threads could cause problem

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Jun 18, 2021
@apupier
Restore code coverage for all tests camel-tooling#313
a2deadd 
ensure threads are finished when test is finished as remaining threads
could cause problem

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apupier