Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support websocket connection #260

Closed
apupier opened this issue Jul 31, 2019 · 6 comments
Closed

Support websocket connection #260

apupier opened this issue Jul 31, 2019 · 6 comments
Assignees
@apupier

Comments

@apupier
Copy link
Member

apupier commented Jul 31, 2019

Currently the connection is on stdin/stdout.
it would be useful to have websocket connection available so can be consumed from https://github.com/wylieconlon/lsp-editor-adapter
@apupier
Copy link
Member Author

apupier commented Jul 31, 2019

Websocket connection in lsp4J is coming in 0.8 version, planned to be released in August eclipse-lsp4j/lsp4j#203

@apupier apupier mentioned this issue Jul 31, 2019
Closed
apupier added a commit to apupier/camel-language-server that referenced this issue Jul 31, 2019
@apupier
WIP camel-tooling#260
0e0c82d 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Member Author

apupier commented Jul 31, 2019

possible start o fimplementation https://github.com/apupier/camel-language-server-1/tree/260-provideWebsocketConnection but not sure what is the simplest way to use the javax.websocket.server.ServerEndpointConfig

apupier added a commit to apupier/camel-language-server that referenced this issue Sep 20, 2019
@apupier
WIP camel-tooling#260
6b93cba 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Member Author

apupier commented Sep 20, 2019

as we ar enot using a classical SpringBoot project but just repackaging using springboot. I'm wondering if it is not easier/lighter to use the reference implementation Tyrus: https://tyrus-project.github.io/documentation/1.12/index/getting-started.html

apupier added a commit to apupier/camel-language-server that referenced this issue Sep 23, 2019
@apupier
WIP camel-tooling#260
2cd0c70 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 23, 2019
@apupier
Provide websocket support camel-tooling#260
0a29784 
- use Tyrus, the reference implementation
- connection through non-configurable port 8025
- camel server jar needs to launched with --websocket

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 23, 2019
@apupier
Provide websocket support camel-tooling#260
dbf7e78 
- use Tyrus, the reference implementation
- connection through non-configurable port 8025
- camel server jar needs to launched with --websocket

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 24, 2019
@apupier
Test Websocket server can start camel-tooling#260
f6fa846 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 24, 2019
@apupier
Test Websocket server can start camel-tooling#260
fbe0389 
the messageLtatch is used to ensure the server has been started before
trying to connect

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Sep 25, 2019
@apupier
Provide websocket support #260
1cbe522 
- use Tyrus, the reference implementation
- connection through non-configurable port 8025
- camel server jar needs to launched with --websocket

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit that referenced this issue Sep 25, 2019
@apupier
Test Websocket server can start #260
727f7a8 
the messageLtatch is used to ensure the server has been started before
trying to connect

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier self-assigned this Sep 25, 2019
@apupier
Copy link
Member Author

apupier commented Sep 25, 2019 •
edited
Loading

follow-up:

@apupier
Copy link
Member Author

apupier commented Sep 25, 2019

to test it manually, recommend to use the CodeMirror example https://github.com/camel-tooling/camel-lsp-client-codemirror

@djelinek
Copy link
Member

djelinek commented Oct 4, 2019

verified with GitHub codemirror example and locally started LSP server with --websocket parameter

@djelinek djelinek closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apupier apupier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apupier @djelinek