fix: fix bugs and update openai_compatible_model #2287
+6
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wendong-Fan
reviewed
Apr 29, 2025
This parameter was updated here, but methods like click were not. |
Wendong-Fan
reviewed
May 5, 2025
Comment on lines
-513
to
-528
| def ask_question_about_video(self, question: str) -> str: | ||
| r"""Ask a question about the video on the current page, | ||
| such as YouTube video. | ||
| Args: | ||
| question (str): The question to ask. | ||
| Returns: | ||
| str: The answer to the question. | ||
| """ | ||
| video_analyzer = VideoAnalysisToolkit() | ||
| result = video_analyzer.ask_question_about_video( | ||
| self.page_url, question | ||
| ) | ||
| return result | ||
|
|
There was a problem hiding this comment.
instead of removing this function, I think we can just fix the bug to remain the original functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually,
self.page_urlin code below does not get updated during the use of BrowserToolkit, so I've temporarily removed this method.Additionally, the BadRequest issue that might occur in
OpenAICompatibleModelhas been resolved.Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!