feat: KnowNo implementation #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuggleJinx
requested review from
lightaime and
Wendong-Fan
and removed request for
lightaime
Wendong-Fan
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
thanks @MuggleJinx ! Left some comment for minor suggestion and updated in commit: 4650779
camel/agents/chat_agent.py
Outdated
Comment on lines
525
to
530
| def update_reasoning( | ||
| self, | ||
| input_message: BaseMessage, | ||
| reason_params: Optional[Dict[str, Any]] = None, | ||
| ) -> BaseMessage: | ||
| r"""Update the reasoning of the agent.""" |
There was a problem hiding this comment.
make this function internal and add docstring
There was a problem hiding this comment.
file naming is not standard
Comment on lines
25
to
28
| model_platform=ModelPlatformType.OPENAI, | ||
| model_type=ModelType.GPT_4O, | ||
| model_config_dict=ChatGPTConfig().as_dict(), | ||
| ) |
There was a problem hiding this comment.
use ModelPlatformType.DEFAULT and ModelType.DEFAULT for examples
| openai_agent = ChatAgent( | ||
| system_message=sys_msg, | ||
| model=openai_model, | ||
| message_window_size=10, |
JoyceXu02
pushed a commit
that referenced
this pull request
Feb 24, 2025
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com> Co-authored-by: Wendong <w3ndong.fan@gmail.com>
ZackZikaiXiao
pushed a commit
to ZackZikaiXiao/camel
that referenced
this pull request
Mar 23, 2025
Co-authored-by: Wendong-Fan <133094783+Wendong-Fan@users.noreply.github.com> Co-authored-by: Wendong <w3ndong.fan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #1542.
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlandpoetry.lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!