Skip to content

Conversation

@gustavonmartins
Copy link
Contributor

What issue does this PR close

Closes #25

Changes Proposed ( a list of new changes introduced by this PR)

Lists objectives in ascending other

How to test ( a list of instructions on how to test this PR)

@zacck-zz
Copy link
Contributor

@namoscagnm I think for a new feature like this it would be very beneficial to add unit tests so that we can ensure regression doesn't occur down the line ...

@lucca65
Copy link
Member

lucca65 commented Feb 10, 2020

nice @namoscagnm! thanks for the contribution. Please add the unit tests and we can merge this 💪

@lucca65
Copy link
Member

lucca65 commented Feb 17, 2020

we can all meet on the support group: https://t.me/Cambiatus_Support

@lucca65
Copy link
Member

lucca65 commented Feb 17, 2020

In anyways doing unit tests isn't hard at all @namoscagnm. Elixir's documentation is, as always, incredible. Please take a look: https://hexdocs.pm/ex_unit/ExUnit.html

I'm sure doing this test is possible even without assistance, but please ping us in the group if you need anything

@lucca65
Copy link
Member

lucca65 commented Feb 25, 2020

I'll merge this and do the tests in a different PR due to inactivity. Thanks for the contribution anyway @namoscagnm

@lucca65 lucca65 merged commit 78d3455 into cambiatus:master Feb 25, 2020
@lucca65
Copy link
Member

lucca65 commented Feb 25, 2020

Just so you know, @namoscagnm the code you sent was not behaving correctly.

here is one of the ways to do it correctly:

  def query(Objective, _) do
    Objective
    |> order_by([c], desc: c.created_at)
  end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort objectives

3 participants