Fix/api file names #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stroncoso-quobis
requested review from
sushanthmavenir and
pradeepachar-mavenir
as code owners
|
Line 99 of webrtc-events.yaml
should reflect new path in webrtc-call-handling.yaml |
|
Thanks @rartych for your feedback. Fixed on d45d8e3 Ready to be approved by @sushanthmavenir or @pradeepachar-mavenir and merged. Release team was already informed about the API name changes, so waiting for this to be merged. Best Regards, |
pradeepachar-mavenir
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
According to API Design Guidelines:
api-name is a kebab-case string used to create unique names or values of objects and parameters related to given AP
The API functionalities must be implemented following the specifications of the Open API version 3.0.3 using api-name as the filename and the .yaml
Servers url:
apiRoot variable and the fixed base path containing api-name
Identified by @rartych at #57
Which issue(s) this PR fixes:
Fixes #57
Special notes for reviewers:
Note that Notification-Channel will not be included on final release. Due that, the issue with the URL (ending with /deviceId) won't be fixed on this PR.
Changelog input
Additional documentation
none