-
Notifications
You must be signed in to change notification settings - Fork 3
M4 - V0.10.0 public #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M4 - V0.10.0 public #68
Conversation
|
@Kevsy , @JoseMConde have you any comment? |
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions made (see above)
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - note I can't approve because I'm also in release-management-reviewers, but you have my implicit codeowner approval at least :)
|
@FabrizioMoggio There is at least one critical inconsistency to fix in either the API or test definitions:
Beyond that please check:
|
|
Some clean-up of legacy: please remove the non-compliant schema "ErrResponse" and the unused responses which are using this schema. Beyond that there is a fix of the ErrorInfo schema in CAMARA_common.yaml which will come in a patch release of Commonalities. You can apply it already now as the fix is compliant to r3.3 of the API Design Guide, but it is neither critical nor mandatory for you now: |
|
I suppose that you are aware that this API mentioned in the description is not released:
Normally there shouldn't be any links into /main/ of repositories, but always a concrete release, but that does not exist yet. |
|
"https://notificationSendServer12.supertelco.com" ... supertelco.com is a registered domain. Please use example.com instead. |
Yes, I know. unfortunately this is why I haven't use a direct link to the version. I could better specify that it is just an example. |
But the current link is going directly to the YAML (which has the misleading version 0.93-wip, which is used there since more than a year despite some updates in the meantime). |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes on the actual release PR content proposed.
code/Test_definitions/traffic-influence-postTrafficInfluence.feature
Outdated
Show resolved
Hide resolved
code/Test_definitions/traffic-influence-postTrafficInfluenceDevice.feature
Outdated
Show resolved
Hide resolved
documentation/API_documentation/traffic-influence-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
alignment with main
|
@FabrizioMoggio something went wrong in 17df308 ... it brought the values from the pre-release back. Please check and update. BTW: is there any (other) reason that the PR is not ready for review again? |
|
Is there some pending issue yet? I don't see any, but I have found the PR marked as Draft (it was not me putting it in that status). In my understanding I should have implemented all the suggestions. |
FabrizioMoggio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the comments have been addressed
|
@FabrizioMoggio there seem to be still some inconsistencies between API and test definition:
|
As far as I can see this inconsistency isn't yet fixed: Line 570 still mentions "error code 409 (DENIED_WAIT)" but PATCH responses (lines 585-612) still don't include 409 |
@FabrizioMoggio thanks for addressing (most of) the previous findings. Please address the issues within #68 (comment) and #68 (comment) and we are good to go! |
Fixed with: #77 |
Alignment with main
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FabrizioMoggio
Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - approved as codeowner
What type of PR is this?
What this PR does / why we need it:
This is the M4 PR for the public version of the TI API, for the Fall25 Meta Release. The PR changes the API version from WIP to 0.10.0 ad provides the updated README.md and CHANGELOG.md files.
Which issue(s) this PR fixes
#67