add subscriptionMaxEvents for maximum number of SIMSwap notifications #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sim-swap-notification-subscription.yaml add subscriptionMaxEvents for maximum number of notifications
bigludo7
requested review from
DT-DawidWroblewski and
fernandopradocabrillo
as code owners
fernandopradocabrillo
previously approved these changes
Mar 8, 2024
Collaborator
fernandopradocabrillo
left a comment
fernandopradocabrillo
left a comment
There was a problem hiding this comment.
LGTM in advance
Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>
gregory1g
reviewed
Mar 11, 2024
Collaborator
|
Following pattern that has been approved inside commonalities. If changes are introduced to this pattern - new PR shall be provided. |
Collaborator
|
@bigludo7 WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Update sim-swap-notification-subscription.yaml
add subscriptionMaxEvents for maximum number of notifications for alignement with commonalities guideline
Which issue(s) this PR fixes:
Fixes #90
Special notes for reviewers:
I keep the version as 0.1.0-wip
Changelog input
Additional documentation
This section can be blank.