prepare r3.3 #239
prepare r3.3 #239
Conversation
fernandopradocabrillo
requested review from
a team,
bigludo7 and
maxl2287
as code owners
@bigludo7 Do you have already reviewed from ReleaseManagement perspective or only as codeowner? I just created the review issue in ReleaseManagement. |
as codeowner only. |
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion and one correction for the CHANGELOG.md file.
Beyond that:
- I agree in general to keep the API Version number if only the test definition(s) are changed (as long as the test are not direct a different semantic behavior)
- But maybe it would be good to amend the first line of the .feature file with something like
(updated in r3.3)so that someone who has both versions can distinguish them.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Hi @hdamker! I don't know about this one, it would be something extra to maintain or to remember to remove for the next one and I don't see that much benefit tbh. |
Fine for me. Just wanted to make it easier for implementors of the tests. |
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
LGTM. Approved on behalf of ReleaseManagement.
|
Needs a final approval from one @camaraproject/sim-swap_codeowners |
bigludo7
left a comment
bigludo7
left a comment
There was a problem hiding this comment.
Thanks !
Approved as codeowner.
3 participants
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Preparations for maintenance release r3.3.
This release updates de test plan to include missing conditions and align with latest Commonalities artifact components