-
Notifications
You must be signed in to change notification settings - Fork 28
Public r3.2 - M4 - Fall25 #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public r3.2 - M4 - Fall25 #229
Conversation
|
Approved for me as Code owner but as I'm part of the @camaraproject/release-management_reviewers I cannot approve it now to avoid approval collision. |
|
Please fix first the Gherkin linting errors in PR #230, don't use the release PR for that (BTW: they are relevant beyond just whitespace issues). After these PRs are done, merge |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
|
As @fernandopradocabrillo is enjoying well-deserved rest this week, I've updated this PR to fix all remaining issues. I think @hdamker we're good to invite for review the release management team WDYT? |
@bigludo7 Agree. I have dismissed my previous review as the requested changes are applied and added the release reviewer team again. Release review issue is anyway already existing, thanks to @Kevsy |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find below my review comments, please address them as soon as possible.
documentation/API_documentation/sim-swap-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
|
@camaraproject/sim-swap_codeowners Please address the above review comments asap or let us know when it will happen. |
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve as code owner (and not as release review management team)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fernandopradocabrillo
Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
P.S.: if you decide to correct the typos as suggested below I'm happy to approve again afterwards.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
c768f7e
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
|
Thanks @hdamker for the review! I've applied the suggested changes. Please approve again whenever you can |
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve as code owner
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve as code owner
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Preparations for M4 Public Release of sim-swap and sim-swap-subscriptions
Which issue(s) this PR fixes:
Fixes #203