Skip to content

Conversation

@fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Preparations for M4 Public Release of sim-swap and sim-swap-subscriptions

Which issue(s) this PR fixes:

Fixes #203

@fernandopradocabrillo fernandopradocabrillo added the Fall25 Meta-release Fall25 label Aug 19, 2025
@bigludo7
Copy link
Collaborator

bigludo7 commented Aug 19, 2025

Approved for me as Code owner but as I'm part of the @camaraproject/release-management_reviewers I cannot approve it now to avoid approval collision.

@hdamker
Copy link
Collaborator

hdamker commented Aug 23, 2025

@fernandopradocabrillo

Please fix first the Gherkin linting errors in PR #230, don't use the release PR for that (BTW: they are relevant beyond just whitespace issues).
And there are already too many changes here in the PR - please consider to create a separate PR first for the Commonalities alignment.

After these PRs are done, merge main into the PR here. Consider to set the release PR to draft until then.

@hdamker
Copy link
Collaborator

hdamker commented Aug 23, 2025

And there are already too many changes here in the PR - please consider to create a separate PR first for the Commonalities alignment.

For your convenience I've created PR #232 based on your commit f3d400a. Please review and merge that PR first and then update the PR here.

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@bigludo7
Copy link
Collaborator

As @fernandopradocabrillo is enjoying well-deserved rest this week, I've updated this PR to fix all remaining issues. I think @hdamker we're good to invite for review the release management team WDYT?

@hdamker hdamker dismissed their stale review August 26, 2025 07:48

Requested changes are applied

@hdamker hdamker requested a review from a team August 26, 2025 07:52
@hdamker
Copy link
Collaborator

hdamker commented Aug 26, 2025

As @fernandopradocabrillo is enjoying well-deserved rest this week, I've updated this PR to fix all remaining issues. I think @hdamker we're good to invite for review the release management team WDYT?

@bigludo7 Agree. I have dismissed my previous review as the requested changes are applied and added the release reviewer team again. Release review issue is anyway already existing, thanks to @Kevsy

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find below my review comments, please address them as soon as possible.

@hdamker
Copy link
Collaborator

hdamker commented Sep 9, 2025

@camaraproject/sim-swap_codeowners Please address the above review comments asap or let us know when it will happen.

bigludo7
bigludo7 previously approved these changes Sep 15, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as code owner (and not as release review management team)

hdamker
hdamker previously approved these changes Sep 16, 2025
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fernandopradocabrillo

Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

P.S.: if you decide to correct the typos as suggested below I'm happy to approve again afterwards.

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@fernandopradocabrillo
Copy link
Collaborator Author

Thanks @hdamker for the review! I've applied the suggested changes. Please approve again whenever you can

bigludo7
bigludo7 previously approved these changes Sep 17, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as code owner

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as code owner

@fernandopradocabrillo fernandopradocabrillo merged commit 6105d77 into camaraproject:main Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fall25 Meta-release Fall25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sim Swap (and subscriptions) - Preparing the scope for meta release Fall25

3 participants