[sim-swap-subscriptions]: remove allof in sinkcredential

[dfischer-tech]

What type of PR is this?

Add one of the following kinds:

• correction

What this PR does / why we need it:

Removing this allOf.
It was discovered for some code-generator, it will produce unexpected behaviours having the description inside the allOf.

Which issue(s) this PR fixes:

Fixes #174

Changelog input

[sim-swap-subscriptions]: remove `allOf` in `sinkCredential` in `SubscriptionRequest` component

[bigludo7]

LGTM
Aligned with commonalities event-subscription-template.yaml

[fernandopradocabrillo]

LGTM

[bigludo7]

@fernandopradocabrillo This request is aligned with current commonalities rules (here line 299-300) so I guess we can merge it and have in r1.4. WDYT?

[fernandopradocabrillo]

@fernandopradocabrillo This request is aligned with current commonalities rules (here line 299-300) so I guess we can merge it and have in r1.4. WDYT?

Fine for me. It doesn't change the API functionality, just the structure of the schema so I don't think we need to update the API version. We can include it, I'll remove the don't merge tag

[bigludo7]

Hello @dfischer-tech
May I ask to change the version in the yam to wip.
Lines 64 & 71.

I will then merge this one. It will be part of next release.
Thanks

[bigludo7]

May I ask to change the version in the yam to wip.
Lines 64 & 71.

[bigludo7]

@dfischer-tech @fernandopradocabrillo I've changed the version accordingly.

Fernando if ok for you we can merge :)