Skip to content

Conversation

@chinaunicomyangfan
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of region-device-count v0.2.0

@chinaunicomyangfan chinaunicomyangfan changed the title Fall25 m4 Release r2.2 (Fall'25 M4) Aug 29, 2025
@chinaunicomyangfan chinaunicomyangfan requested a review from a team August 29, 2025 06:58
Updates descriptions in ErrorModel
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Nice job ! thanks
See my review comments on behalf of the release management team.

I need also to get a confirmation from you that API description here is up-to-date.

CHANGELOG.md Outdated
## Release Notes


This release contains the definition and documentation of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add public here:
This public release contains the definition....

CHANGELOG.md Outdated
* Update pattern for x-correlator in https://github.com/camaraproject/RegionDeviceCount/pull/58

API definition **with inline documentation**:
[[YAML]](https://github.com/camaraproject/RegionDeviceCount/blob/r2.1/code/API_definitions/region-device-count.yaml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be r2.2 in the url

CHANGELOG.md Outdated

API definition **with inline documentation**:
[[YAML]](https://github.com/camaraproject/RegionDeviceCount/blob/r2.1/code/API_definitions/region-device-count.yaml)
[[View it on ReDoc]](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/r2.1/code/API_definitions/region-device-count.yaml&nocors)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be r2.2 in the url

@bigludo7 bigludo7 requested a review from a team September 4, 2025 10:35
@chinaunicomyangfan
Copy link
Collaborator Author

Hello, Nice job ! thanks See my review comments on behalf of the release management team.

I need also to get a confirmation from you that API description here is up-to-date.

@bigludo7 Thanks a lot for the review ,I think I have updated the file based on your comments , and I believe the API description is up-to-date

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinaunicomyangfan Please address #64 in a short PR before the release.

@chinaunicomyangfan
Copy link
Collaborator Author

@chinaunicomyangfan Please address #64 in a short PR before the release.

@hdamker Thanks for the comment,I have add the notificationsBearerAuth definition here

@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 9, 2025

HI @chinaunicomyangfan
Thanks for the quick update.

Few additional requests:

  • Missing the Mandatory template for info.description as defined here. My suggestion is to add it but also please keep what you have proposed:
# Authorization and authentication

The "Camara Security and Interoperability Profile" provides details of how an API consumer requests an access token. Please refer to Identity and Consent Management (https://github.com/camaraproject/IdentityAndConsentManagement/) for the released version of the profile.

The specific authorization flows to be used will be agreed upon during the onboarding process, happening between the API consumer and the API provider, taking into account the declared purpose for accessing the API, whilst also being subject to the prevailing legal framework dictated by local legislation.

In cases where personal data is processed by the API and users can exercise their rights through mechanisms such as opt-in and/or opt-out, the use of three-legged access tokens is mandatory. This ensures that the API remains in compliance with privacy regulations, upholding the principles of transparency and user-centric privacy-by-design.

Region Device Count API does not involve the input and output of user personal data.Therefore, the access to Region Device Count APII is defined as `Client Credentials - 2-legged`. Please refer to [Identify and Consent Management](https://github.com/camaraproject/IdentityAndConsentManagement/) for the latest detailed specification of this authentication/authorization flow.
  • Test file uses incorrect API name regionDeviceCount (should be region-device-count) - as defined here
  • region-device-count: Scope Naming - Scope name should follow pattern api-name:[resource:]action: region-device-count (minor but very easy to fix) - as defined here

Thanks again for your contribution :)

@chinaunicomyangfan
Copy link
Collaborator Author

@bigludo7
Thank you for your suggestion. I have fixed the first two problems, but I haven't found the last one where the scope should be modified. Can you give me some guidance.

region-device-count: Scope Naming - Scope name should follow pattern api-name:[resource:]action: region-device-count (minor but very easy to fix)

@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 9, 2025

@chinaunicomyangfan Sure !
This is the line 185 - very small change required.
You have - region-device-count but the guideline requires for the scope value to use pattern api-name:[resource:]action
so you should have a scope valued to - region-device-count:count

@bigludo7 bigludo7 requested review from a team and removed request for a team September 10, 2025 06:28
bigludo7
bigludo7 previously approved these changes Sep 10, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

@chinaunicomyangfan
Copy link
Collaborator Author

@bigludo7 To align with the API description on Wiki. I have modified the API description in the Readme file in this PR. Please review again.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes of github.com and githubusercontent.com domains back to the official domains.

@hdamker hdamker dismissed their stale review September 12, 2025 07:46

Just seen that it was already corrected in e6c706b. Sorry for the noise.

This functionality can be used for multiple use cases, some of the possible use cases for this API are:
- [Emergency Rescue](https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md)
- [Emergency Rescue](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change need still to be reverted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,done

- [Emergency Rescue](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md)
- [Outdoor Live Streaming](https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Outdoor_Live_Streaming.md)
- [Outdoor Live Streaming](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Outdoor_Live_Streaming.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,done

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hdamker for the review and @chinaunicomyangfan for the correction.

We're now go to go :)

Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

Thanks

Copy link

@ChuanyuChen ChuanyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@chinaunicomyangfan chinaunicomyangfan merged commit c855ee8 into camaraproject:main Sep 15, 2025
2 checks passed
@chinaunicomyangfan
Copy link
Collaborator Author

@bigludo7 Thanks for the review.I have create a new public release r2.2 ,and the tracker has been updated.
Please check,thanks

@bigludo7
Copy link
Collaborator

Everything look very good :)
Thanks @chinaunicomyangfan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants