-
Notifications
You must be signed in to change notification settings - Fork 3
Release r2.2 (Fall'25 M4) #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r2.2 (Fall'25 M4) #62
Conversation
Updates descriptions in ErrorModel
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Nice job ! thanks
See my review comments on behalf of the release management team.
I need also to get a confirmation from you that API description here is up-to-date.
CHANGELOG.md
Outdated
| ## Release Notes | ||
|
|
||
|
|
||
| This release contains the definition and documentation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add public here:
This public release contains the definition....
CHANGELOG.md
Outdated
| * Update pattern for x-correlator in https://github.com/camaraproject/RegionDeviceCount/pull/58 | ||
|
|
||
| API definition **with inline documentation**: | ||
| [[YAML]](https://github.com/camaraproject/RegionDeviceCount/blob/r2.1/code/API_definitions/region-device-count.yaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be r2.2 in the url
CHANGELOG.md
Outdated
|
|
||
| API definition **with inline documentation**: | ||
| [[YAML]](https://github.com/camaraproject/RegionDeviceCount/blob/r2.1/code/API_definitions/region-device-count.yaml) | ||
| [[View it on ReDoc]](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/r2.1/code/API_definitions/region-device-count.yaml&nocors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be r2.2 in the url
@bigludo7 Thanks a lot for the review ,I think I have updated the file based on your comments , and I believe the API description is up-to-date |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chinaunicomyangfan Please address #64 in a short PR before the release.
@hdamker Thanks for the comment,I have add the notificationsBearerAuth definition here |
|
HI @chinaunicomyangfan Few additional requests:
Thanks again for your contribution :) |
|
@bigludo7
|
|
@chinaunicomyangfan Sure ! |
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
|
@bigludo7 To align with the API description on Wiki. I have modified the API description in the Readme file in this PR. Please review again. |
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all changes of github.com and githubusercontent.com domains back to the official domains.
Just seen that it was already corrected in e6c706b. Sorry for the noise.
| This functionality can be used for multiple use cases, some of the possible use cases for this API are: | ||
| - [Emergency Rescue](https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md) | ||
| - [Emergency Rescue](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change need still to be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,done
| - [Emergency Rescue](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Emergency_Rescue.md) | ||
| - [Outdoor Live Streaming](https://raw.githubusercontent.com/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Outdoor_Live_Streaming.md) | ||
| - [Outdoor Live Streaming](https://raw.bgithub.xyz/camaraproject/RegionDeviceCount/main/documentation/API_documentation/RDC_User_Story_Outdoor_Live_Streaming.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,done
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hdamker for the review and @chinaunicomyangfan for the correction.
We're now go to go :)
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
Thanks
ChuanyuChen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
|
Everything look very good :) |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Publication of Fall'25 M4 public release of region-device-count v0.2.0