Skip to content

Conversation

@chinaunicomyangfan
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • bug

What this PR does / why we need it:

The version number identification in the YAML file is incorrect because it was forgotten to be modified when releasing the public version.

Which issue(s) this PR fixes:

Fixes #51

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinaunicomyangfan Unfortunately this need to be done together as a patch release. Just updating in it in the main branch will leave the release tree r1.2 still with the wrong version number.

The way to do it is quite simple:

  • rename this PR, e.g. "Patch release r1.3 with ..."
  • go through the files and replace r1.2 with r1.3
  • add a short section in the beginning of the changelog with the standard intro and the short note that this patch release is just correcting the version number in the API definition file

I will configure the CODEOWNERS file so that release management is automatically included as reviewers if you touch the CHANGELOG.md

@chinaunicomyangfan
Copy link
Collaborator Author

@hdamker I have changed ChangeLog and Readme file for the release of r1.3.
Please review if there are any other files that need to be modified.Thanks

@hdamker hdamker changed the title change version num from v0.1.0-rc1 to v0.1.0 Release PR r1.3 - Patch to change version num from v0.1.0-rc1 to v0.1.0 May 27, 2025
@hdamker hdamker requested a review from a team May 27, 2025 10:09
@hdamker
Copy link
Contributor

hdamker commented May 27, 2025

@hdamker I have changed ChangeLog and Readme file for the release of r1.3.
Please review if there are any other files that need to be modified.Thanks

@chinaunicomyangfan LGTM. I have just updated the release number in the checklist and deleted two obsolete README files (they are only there to create initially the folder).

Also created the release review issue as we need it to propagate the new release number.

@hdamker
Copy link
Contributor

hdamker commented Jun 3, 2025

@chinaunicomyangfan the PR is ready to be merged and the release can be created. Please let me know if you need any support for it. See also camaraproject/ReleaseManagement#212

Copy link

@ChuanyuChen ChuanyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok。

@chinaunicomyangfan chinaunicomyangfan merged commit 6f45d30 into camaraproject:main Jun 4, 2025
2 checks passed
@chinaunicomyangfan
Copy link
Collaborator Author

@chinaunicomyangfan the PR is ready to be merged and the release can be created. Please let me know if you need any support for it. See also camaraproject/ReleaseManagement#212

@hdamker The PR has been merged and I have create a new public release r1.3,please check what else I need to do.

@hdamker
Copy link
Contributor

hdamker commented Jun 4, 2025

@hdamker The PR has been merged and I have create a new public release r1.3,please check what else I need to do.

Thanks. Two things (which I have already done for you):

  • for consistency we just copy the section of the CHANGELOG into the release description (done)
  • last step on your side would have been the update of the release tracker (done)

@chinaunicomyangfan
Copy link
Collaborator Author

@hdamker The PR has been merged and I have create a new public release r1.3,please check what else I need to do.

Thanks. Two things (which I have already done for you):

  • for consistency we just copy the section of the CHANGELOG into the release description (done)
  • last step on your side would have been the update of the release tracker (done)

A big thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect version number in region-device-count.yaml (shows 0.1.0-rc.1 instead of 0.1.0)

4 participants