-
Notifications
You must be signed in to change notification settings - Fork 3
Release PR r1.3 - Patch to change version num from v0.1.0-rc1 to v0.1.0 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PR r1.3 - Patch to change version num from v0.1.0-rc1 to v0.1.0 #53
Conversation
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chinaunicomyangfan Unfortunately this need to be done together as a patch release. Just updating in it in the main branch will leave the release tree r1.2 still with the wrong version number.
The way to do it is quite simple:
- rename this PR, e.g. "Patch release r1.3 with ..."
- go through the files and replace r1.2 with r1.3
- add a short section in the beginning of the changelog with the standard intro and the short note that this patch release is just correcting the version number in the API definition file
I will configure the CODEOWNERS file so that release management is automatically included as reviewers if you touch the CHANGELOG.md
|
@hdamker I have changed ChangeLog and Readme file for the release of r1.3. |
@chinaunicomyangfan LGTM. I have just updated the release number in the checklist and deleted two obsolete README files (they are only there to create initially the folder). Also created the release review issue as we need it to propagate the new release number. |
|
@chinaunicomyangfan the PR is ready to be merged and the release can be created. Please let me know if you need any support for it. See also camaraproject/ReleaseManagement#212 |
ChuanyuChen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok。
@hdamker The PR has been merged and I have create a new public release r1.3,please check what else I need to do. |
Thanks. Two things (which I have already done for you):
|
A big thanks to you! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
The version number identification in the YAML file is incorrect because it was forgotten to be modified when releasing the public version.
Which issue(s) this PR fixes:
Fixes #51