-
Notifications
You must be signed in to change notification settings - Fork 9
admin: migrate to centralized linting workflows #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: migrate to centralized linting workflows #75
Conversation
Applied via project-admin workflow Repository: HomeDevicesQoD Operation: centralize-linting-workflows
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
|
@camaraproject/home-devices-qod_codeowners: the error/issues within test definition file are only whitespace changes. Nevertheless would it be good to make a plan when this API will be updated towards the latest Commonalities. My expectation is that this happens latest within the Fall26 meta-release cycle, as the API wasn't updated since its release in Fall24. |
jpengar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed indentation errors. LGTM
hdamker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this isn't anymore the "0.4.0" version I suggest to set version within API and Test definition to "wip" before merging the changes.
@hdamker I can address that, but there are no plans to evolve this API and it is a candidate for archiving |
|
@jpengar Good to know ... in this case it is also an option "to do nothing" and keep the main branch untouched until there is a decision. The PR was created together with the ones for all Sandbox repositories, independent of their status beyond the fact that they hadn't yet the centralized linting. |
@hdamker I think we can merge this PR as it is and leave the 'WIP' version change aside for the time being, until the process of archiving this API has been confirmed. This doesn't need to be a dependency, so we can close this topic. |
@hdamker agrees to merge the PR as is in #75 (comment)
CAMARA Project Admin Update - Linting Migration
This pull request migrates this repository from local linting configuration to centralized linting workflows managed by the CAMARA project.
🔄 Migration Summary
Removed local linting artifacts:
megalinter.ymlspectral_oas_lint.yml.spectral.yml.yamllint.yaml/lint_function/Added centralized workflows:
spectral-oas-caller.yml- Spectral linting with CAMARA rulesetpr_validation_caller.yml- Comprehensive PR validation✨ Benefits of Centralized Linting
📋 What This Means for You
🔧 Technical Details
The new workflows reference reusable workflows from:
camaraproject/tooling/.github/workflows/This ensures all repositories benefit from:
👥 Next Steps for Codeowners
Note on Linting Checks: The linting workflows are currently not blocking - they will not prevent this PR (or future PRs) from being merged. However, it is highly recommended to:
This approach maintains code quality while allowing flexibility during the transition period.
Before Merging This PR:
Review linting results in PR checks:
Fix linting errors (strongly recommended):
Approve and merge this PR 🚀
After Merge:
Establish linting best practices:
Test with additional rules (optional):
Monitor future PRs:
💡Pro tip: Running the Spectral workflow manually NOW is highly recommended. This allows you to identify and fix issues proactively rather than discovering them when submitting your next feature PR!
🤖 Generated via project-admin workflow
Triggered by hdamker, executed via hdamker-bot
➡️ Next Steps: This PR should be reviewed, fixed as needed, approved, and merged by repository codeowners following standard review processes.
This is a manually triggered automated administrative update.