-
Notifications
You must be signed in to change notification settings - Fork 35
Create public r3.2 (M4 Fall25) #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@jlurien which of the open PRs are actually planned for Fall25 still? |
Kevsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codeowner fixes required following release management review
As well as my inline suggestions above, please can you make the following changes:
- geofencing-subscriptions.yaml
Please change the URL part /main/ to /r3.2/ in the links in these two lines:
Line 675
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#122-event-notification). |
Line 727
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#122-event-notification). |
- All .feature files
Please add this line under# Implementation indicationsin each .feature file:
# * apiRoot: API root of the server URL
That is unfortunately not the solution as the document within the link is deprecated - I opened in Commonalities (camaraproject/Commonalities#531), as this is also within the template. Short-term I recommend to copy the definition from sim-swap-subscription, if @bigludo7 has not a better proposal. |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
|
@Kevsy All your requests fixed - Thanks for the review Regarding the link to obscolete doc I've updated but perhaps let's wait camaraproject/Commonalities#531 outcome. |
maxl2287
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @bigludo7
|
(This looks good from my release-management and automated review, but I will wait to approve until we know the Commonalities decision, as @bigludo7 says) |
|
Following the Commonalities decision to accept the amended event-subscription-template text, I'm happy to approve 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
What type of PR is this?
What this PR does / why we need it:
Applies changes to be merged prior to the creation of the next public release r3.2
Which issue(s) this PR fixes:
Fixes #370
Special notes for reviewers:
All other PRs in the scope for Fall25 must be merged prior to this one, and this one realigned with master