Skip to content

Conversation

@jlurien
Copy link
Collaborator

@jlurien jlurien commented Sep 1, 2025

What type of PR is this?

  • documentation
  • subproject management

What this PR does / why we need it:

Applies changes to be merged prior to the creation of the next public release r3.2

Which issue(s) this PR fixes:

Fixes #370

Special notes for reviewers:

All other PRs in the scope for Fall25 must be merged prior to this one, and this one realigned with master

docs

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 3 0 4.6s
✅ GHERKIN gherkin-lint 3 0 1.18s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.78s
✅ YAML yamllint 3 0 1.01s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@jlurien jlurien added the Fall25 Meta-release Fall25 label Sep 1, 2025
@hdamker
Copy link
Contributor

hdamker commented Sep 2, 2025

All other PRs in the scope for Fall25 must be merged prior to this one, and this one realigned with master

@jlurien which of the open PRs are actually planned for Fall25 still?

@jlurien jlurien marked this pull request as ready for review September 2, 2025 14:55
@jlurien jlurien requested review from a team, bigludo7 and maxl2287 as code owners September 2, 2025 14:55
@hdamker hdamker changed the title Create public r3.2 Create public r3.2 (M4 Fall25) Sep 7, 2025
@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 9, 2025

All other PRs in the scope for Fall25 must be merged prior to this one, and this one realigned with master

@jlurien which of the open PRs are actually planned for Fall25 still?

None - #336 & #335 are tagged as draft and planned for Spring26.

Copy link
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowner fixes required following release management review

As well as my inline suggestions above, please can you make the following changes:

  1. geofencing-subscriptions.yaml

Please change the URL part /main/ to /r3.2/ in the links in these two lines:

Line 675

description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#122-event-notification).

Line 727

description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#122-event-notification).

  1. All .feature files
    Please add this line under # Implementation indications in each .feature file:

# * apiRoot: API root of the server URL

@hdamker
Copy link
Contributor

hdamker commented Sep 12, 2025

  1. geofencing-subscriptions.yaml

Please change the URL part /main/ to /r3.2/ in the links in these two lines:

That is unfortunately not the solution as the document within the link is deprecated - I opened in Commonalities (camaraproject/Commonalities#531), as this is also within the template. Short-term I recommend to copy the definition from sim-swap-subscription, if @bigludo7 has not a better proposal.

@bigludo7
Copy link
Collaborator

@Kevsy All your requests fixed - Thanks for the review

Regarding the link to obscolete doc I've updated but perhaps let's wait camaraproject/Commonalities#531 outcome.

Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bigludo7

@maxl2287 maxl2287 requested a review from Kevsy September 15, 2025 09:28
@Kevsy
Copy link
Collaborator

Kevsy commented Sep 15, 2025

(This looks good from my release-management and automated review, but I will wait to approve until we know the Commonalities decision, as @bigludo7 says)

@Kevsy
Copy link
Collaborator

Kevsy commented Sep 16, 2025

Following the Commonalities decision to accept the amended event-subscription-template text, I'm happy to approve 👍

Copy link
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@bigludo7 bigludo7 merged commit bc17cee into main Sep 16, 2025
2 checks passed
@bigludo7 bigludo7 deleted the create-public-r3.2 branch September 16, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fall25 Meta-release Fall25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare public release for Fall25 M4

6 participants