Improve test-definitions regarding style, structure and format #331
Conversation
… location-retrieval.feature & location-verification.feature
maxl2287
added
tests
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
Some comments, still need to fully review geofencing-subscriptions
|
Geofencing test plan should be aligned with the outcome of camaraproject/Commonalities#470. |
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
|
@maxl2287 I would keep this open until camaraproject/Commonalities#470 is merged and then review that is totally aligned, wdyt? |
…definitions # Conflicts: # code/Test_definitions/geofencing-subscriptions.feature # code/Test_definitions/location-retrieval.feature
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
It seems that geofencing-subscriptiuons.feature is not aligned yet with https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.feature
…definitions # Conflicts: # code/Test_definitions/geofencing-subscriptions.feature # code/Test_definitions/location-retrieval.feature # code/Test_definitions/location-verification.feature
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
Review that stabdar error scenarios are aligned with https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.feature
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
LGTM with 3 corrections that I can apply directly
3 participants
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Improve test-definitions for geofencing-subscriptions.feature, location-retrieval.feature & location-verification.feature
Which issue(s) this PR fixes:
Fixes #330
Changelog input