Remove AUTHENTICATION_REQUIRED error code

[eric-murray]

What type of PR is this?

• correction

What this PR does / why we need it:

Commonalities pre-release r3.1 removes the AUTHENTICATION_REQUIRED error code, leaving UNAUTHENTICATED as the only valid error code when the HTTP status code is 401. This PR removes all instances of AUTHENTICATION_REQUIRED.

Which issue(s) this PR fixes:

Fixes #39

Special notes for reviewers:

This is not a breaking change

Changelog input

 release-note
 - Remove AUTHENTICATION_REQUIRED error code

Additional documentation

None

[eric-murray]

@maxl2287
The line "new-line-at-eof": ["on", "no"] in .gherkin-lintrc is causing me issues as I edit using the github website (on Windows). What is your preferred solution to this problem?

[maxl2287]

@maxl2287 The line "new-line-at-eof": ["on", "no"] in .gherkin-lintrc is causing me issues as I edit using the github website (on Windows). What is your preferred solution to this problem?

Hey @eric-murray,

I am surprised that this occures when there is no new line visible in the file.
I can only see it on https://github.dev/ on your branch that there is a new line.

I am workign with IntelliJ so I do not experienced this behaviour before.

Could it be an issue regarding the line-ending in Windows ? CRLF? Idk. 🤷🏻‍♂️

[eric-murray]

@maxl2287
Yes, that is the issue. Unless github is told otherwise, it adopts the local configuration, and we are obviously using different local configurations. But there is no way to change this for the github web editor.

In the absence of line endings being enforced across the project (using a core.autocrlf setting), it must either be set for the repository (in a .gitattributes file), or the rule to prohibit new-line-at-eof must be removed.

See https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

[maxl2287]

@maxl2287 Yes, that is the issue. Unless github is told otherwise, it adopts the local configuration, and we are obviously using different local configurations. But there is no way to change this for the github web editor.

In the absence of line endings being enforced across the project (using a core.autocrlf setting), it must either be set for the repository (in a .gitattributes file), or the rule to prohibit new-line-at-eof must be removed.

See https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

I am okay with removing this new-line-at-eof.

[eric-murray]

Raised #42