[Device-data-volume-subscriptions]: remove allof in sinkcredential #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravindrapalaskar17
requested review from
maxl2287 and
sachinvodafone
as code owners
sachinvodafone
previously approved these changes
Apr 28, 2025
maxl2287
previously approved these changes
Apr 28, 2025
Contributor
maxl2287
left a comment
maxl2287
left a comment
There was a problem hiding this comment.
LGTM, thanks @ravindrapalaskar17
maxl2287
approved these changes
Apr 28, 2025
Contributor
|
@sachinvodafone is it okay to merge that, because your approval was not removed after I removed the trailing whitespaces 🥲 |
sachinvodafone
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Removing this allOf.
It was discovered for some code-generator, it will produce unexpected behaviors having the description inside the allOf.
Which issue(s) this PR fixes:
Fixes #26
Changelog input