Reset to wip after r1.2 #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkandoi
requested review from
a team,
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
Contributor
Author
|
Closing since this is tricky to do till the r1.2 PR is merged. |
rkandoi
force-pushed
the
reset_to_wip_after_r1.2
branch
from
0128927 to
c6bf66d
Compare
Contributor
Author
|
@tlohmar - this is the first PR that should be merged before others. The PR updates the versions of the API specs, which is the most important thing. The version in the URL in the test case files have also been updated so we can update test cases freely as we continue the work. Will consider making the version a variable as suggested by Herbert in another review to minimize the changes going forward. However please note that I intentionally did not update the versions in the Checklist file as I did not see the meaning in doing that. Hope that understanding is correct. cc: @hdamker, @eric-murray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Reset version to vwip after r1.2 after the release PR is now merged.