Skip to content

Conversation

@eric-murray
Copy link
Contributor

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of:

  • connected-network-type v0.2.0
  • connected-network-type-subscriptions v0.2.0

Which issue(s) this PR fixes:

Fixes #36

Special notes for reviewers:

None

Changelog input

 release-note
 - Publication of Fall'25 M4 public release of connected-network-type v0.2.0 and connected-network-type-subscriptions v0.2.0

Additional documentation

None

@bigludo7
Copy link
Contributor

Hello @eric-murray
We probably need to apply requested modifications listed here: https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/198443045/Analysis+of+Commonalities+0.6.0 and in particular:

  • ErrorInfo scheme unification in CAMARA_common.yaml and event-subscription-template.yaml #506 --> update of ErrorInfo message & status description
  • Changed Mandatory Description for date-time string format and updated template files #497 --> test shortened

@eric-murray
Copy link
Contributor Author

@bigludo7
Yes, that's fine, but should be done as a separate PR, and not as part of this one.

If other PRs cause merge conflicts with this one, I will fix them

sachinvodafone
sachinvodafone previously approved these changes Aug 28, 2025
@rartych
Copy link
Contributor

rartych commented Sep 11, 2025

L426 in connected-network-type-subscriptions.yaml is not valid anymore (API sub-projects are free to decide to allow more than one event type per subscription.)

Note: For the current Commonalities API design guidelines, only one event type per subscription is allowed, yet in the following releases use of array of event types SHALL be specified without changing this definition.

@rartych
Copy link
Contributor

rartych commented Sep 11, 2025

In connected-network-type-subscriptions.yaml (lines 466-475) the text:

Up to API project decision to keep it.

is not needed.

@rartych
Copy link
Contributor

rartych commented Sep 12, 2025

Is using square brackets [] intended here:

- `UNKNOWN`: if connection [technology] can not be determined

@rartych
Copy link
Contributor

rartych commented Sep 12, 2025

Please review suggested changes

@rartych
Copy link
Contributor

rartych commented Sep 12, 2025

Device status server in connected network type API, is it correct:

The Device status server will call this endpoint whenever the connected network type of the device changes.

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@bigludo7
Copy link
Contributor

Thanks @rartych for the review.

All fixed :)

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the link to Commonalities r2.3 into the deprecated API Design Guideline Document. See camaraproject/Commonalities#531 for further background and potential short-term solution.

description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification).

cc: @bigludo7

@bigludo7
Copy link
Contributor

Please address the link to Commonalities r2.3 into the deprecated API Design Guideline Document. See camaraproject/Commonalities#531 for further background and potential short-term solution.

description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification).

cc: @bigludo7

Fixed by replacing with a description without link.

@hdamker hdamker dismissed their stale review September 16, 2025 15:36

Request changes is done

Copy link
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management

@bigludo7 bigludo7 merged commit 643b759 into camaraproject:main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the public release r1.2 for Fall25

5 participants