-
Notifications
You must be signed in to change notification settings - Fork 4
Release r1.2 (Fall'25 M4) #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.2 (Fall'25 M4) #41
Conversation
|
Hello @eric-murray |
|
@bigludo7 If other PRs cause merge conflicts with this one, I will fix them |
|
L426 in connected-network-type-subscriptions.yaml is not valid anymore (API sub-projects are free to decide to allow more than one event type per subscription.)
|
|
In connected-network-type-subscriptions.yaml (lines 466-475) the text:
is not needed. |
|
Is using square brackets [] intended here: ConnectedNetworkType/code/API_definitions/connected-network-type-subscriptions.yaml Line 25 in 86cd1e8
|
code/Test_definitions/connected-network-type-subscriptions.feature
Outdated
Show resolved
Hide resolved
|
Please review suggested changes |
|
Device status server in connected network type API, is it correct: ConnectedNetworkType/code/API_definitions/connected-network-type-subscriptions.yaml Line 166 in 86cd1e8
|
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
…ture Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
|
Thanks @rartych for the review. All fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the link to Commonalities r2.3 into the deprecated API Design Guideline Document. See camaraproject/Commonalities#531 for further background and potential short-term solution.
ConnectedNetworkType/code/API_definitions/connected-network-type-subscriptions.yaml
Line 729 in 6fe9e64
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification). |
cc: @bigludo7
Fixed by replacing with a description without link. |
rartych
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of Release Management
What type of PR is this?
What this PR does / why we need it:
Publication of Fall'25 M4 public release of:
Which issue(s) this PR fixes:
Fixes #36
Special notes for reviewers:
None
Changelog input
Additional documentation
None