Skip to content

Conversation

@Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented Sep 9, 2025

What type of PR is this?

  • correction

What this PR does / why we need it:

Changes the example in the networkAccessIdentifier schema from domain.com (a live commercial web address) to example.com (as reserved in RFC 2606 for such examples).

Which issue(s) this PR fixes:

Fixes #529

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

PedroDiez
PedroDiez previously approved these changes Sep 9, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hdamker
hdamker previously approved these changes Sep 9, 2025
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to include this change still in the r3.4 patch #527

patrice-conil
patrice-conil previously approved these changes Sep 10, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych dismissed stale reviews from patrice-conil, hdamker, and PedroDiez via cb77375 October 3, 2025 11:00
@rartych
Copy link
Contributor

rartych commented Oct 3, 2025

changed supertelco.com --> example.com

@rartych rartych changed the title fix: change networkAccessIdentifier to use example.com fix: change networkAccessIdentifier and notification server example to use example.com Oct 3, 2025
Copy link
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit cb336e9 into camaraproject:main Oct 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: networkAccessIdentifier uses a real domain name in its schema example

5 participants