-
Notifications
You must be signed in to change notification settings - Fork 30
Clarify that the DeviceResponse schema is not mandatory #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
patrice-conil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rartych
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PedroDiez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
patrice-conil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
The Design Guide states that the
DeviceResponseschema should be used to disambiguate which device identifier is being used by an implementation when an API consumer has provided more than one identifier, but it does not mandate it. Nor should it, as there will be APIs for which it is not appropriate. If it is used by an API, however, then it becomes mandatory to provide a single device identifier in the response when multiple are provided in the response.This PR clarifies that:
DeviceResponseschema is not mandatory for an APIWhich issue(s) this PR fixes:
Fixes #489
Does this PR introduce a breaking change?
Special notes for reviewers:
None
Changelog input
Additional documentation
None