Skip to content

Conversation

@PedroDiez
Copy link
Contributor

@PedroDiez PedroDiez commented May 6, 2025

What type of PR is this?

  • enhancement

What this PR does / why we need it:

Provide an aligned text description for duration format fields as explained in #458.
In this way, it avoids additional WG discusions on which description text use.

Which issue(s) this PR fixes:

Fixes #458

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Suggested Note added just to inform Subproject about ambigüity that may generate use of duration fields.
Also use of a start date/time field in combination with a duration format field could help to mitigate ambiguity topics (added also to inform Subproject, at the end it will be up to their consideration) .

Info about this:

Changelog input

 Text description alignment for duration format fields

Additional documentation

This section can be blank.

docs

patrice-conil
patrice-conil previously approved these changes May 12, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
patrice-conil
patrice-conil previously approved these changes May 15, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PedroDiez and others added 2 commits May 15, 2025 19:56
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
patrice-conil
patrice-conil previously approved these changes May 16, 2025
Copy link
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rartych
rartych previously approved these changes May 20, 2025
@Kevsy
Copy link
Collaborator

Kevsy commented May 21, 2025

Very minor typo correction above otherwise LGTM

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@PedroDiez PedroDiez dismissed stale reviews from rartych and patrice-conil via 7b418e2 May 22, 2025 15:14
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@rartych rartych merged commit 013b0d9 into camaraproject:main Jun 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Fall25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align text description for fields of format duration

4 participants