-
Notifications
You must be signed in to change notification settings - Fork 30
String pattern added to x-correlator scheme #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PedroDiez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
patrice-conil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure that we should introduce this as a "breaking change" ... if we do so then all 1.0.0 API versions from Fall24 will go to automatically to 2.x.x in Spring25. I formulated my proposal along the vendor opaque value in Trace Context, to avoid that we exclude any valid vendor specific correlator by this change and therefore don't need to declare it as breaking change. But maybe too late here ... |
|
Formally it is a breaking change (modifying mandatory parameter). |
What type of PR is this?
What this PR does / why we need it:
String pattern added to x-correlator scheme to improve security and inline with current recommendation for string parameters.
The proposed pattern covers recommended UUID strings and the length of 55 allows to use strings similar to
traceparentfrom Trace Context.CAMARA_common.yaml was updated accordingly.
Which issue(s) this PR fixes:
Fixes #352
Does this PR introduce a breaking change?
Special notes for reviewers:
The change should not be breaking for current implementations using UUID in x-correlator.
Changelog input
Additional documentation