Skip to content

Conversation

@HanbaiWang
Copy link
Collaborator

@HanbaiWang HanbaiWang commented Nov 9, 2023

support material

@HanbaiWang HanbaiWang self-assigned this Nov 9, 2023
@HanbaiWang HanbaiWang changed the title Add files via upload CTD support material Nov 9, 2023
Copy link
Collaborator

@ShutingQing ShutingQing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanXu-ChinaTelecom
Copy link
Collaborator

Good material, help to understand this API

@hdamker
Copy link
Contributor

hdamker commented Mar 13, 2024

This PR can't be merged by the sub project itself, as @HanbaiWang is the only codeowner (and can't approve his won PRs).
@HanbaiWang to you want my help to get it merged. There are two approvals, so it should be fine.

@HanbaiWang
Copy link
Collaborator Author

This PR can't be merged by the sub project itself, as @HanbaiWang is the only codeowner (and can't approve his won PRs). @HanbaiWang to you want my help to get it merged. There are two approvals, so it should be fine.

Yes, could you please help me to merge this? Btw could you please add @@ShutingQing as another codeowner of this sub project?(as there should be at least 2 code owner of this project?) Thanks a lot.

@hdamker
Copy link
Contributor

hdamker commented Mar 17, 2024

Yes, could you please help me to merge this? Btw could you please add @@ShutingQing as another codeowner of this sub project?(as there should be at least 2 code owner of this project?) Thanks a lot.

@HanbaiWang I've created #14 ... as soon you have approved and merged it, @ShutingQing is also codeowner. With her approval you can then merge this PR here.

Copy link
Collaborator

@ShutingQing ShutingQing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Herbert, and thanks Hanbai for the material. The slide looks good to me, detailed in API functions, API definitions, refering related standards elaboration. Approve.

@ShutingQing ShutingQing merged commit 7a818e0 into main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants